[PATCH] D154725: [AggressiveInstCombine] Fold strcmp for short string literals

Tue Aug 8 12:37:50 PDT 2023

alexfh added a comment.

In D154725#4570452 <https://reviews.llvm.org/D154725#4570452>, @alexfh wrote:

> In D154725#4570358 <https://reviews.llvm.org/D154725#4570358>, @alexfh wrote:
>
>> In D154725#4568911 <https://reviews.llvm.org/D154725#4568911>, @xbolva00 wrote:
>>
>>> This is serious, please fix or revert from release branches.
>>
>> I'll prepare a revert in case @kitaisreal doesn't respond soon.
>>
>> Here a slightly more convenient reproducer (dumped IR right before the AggressiveInstCombine pass): https://gcc.godbolt.org/z/bGn3EnWG6
>
> The commit can't be reverted cleanly, I'll have to also revert dependent commits: cbfcf90152de5392a36d0a0241eef25f5e159eef <https://reviews.llvm.org/rGcbfcf90152de5392a36d0a0241eef25f5e159eef> and 5dde755188e34c0ba5304365612904476c8adfda <https://reviews.llvm.org/rG5dde755188e34c0ba5304365612904476c8adfda>.

Prepared a revert of the three commits here: https://reviews.llvm.org/D157430. I'm running tests now and will land the revert once they finish, unless I hear any objections.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154725/new/

https://reviews.llvm.org/D154725