[PATCH] D157426: [AMDGPU][True16] Fix ISel for A16 Image Instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 12:01:49 PDT 2023


Joe_Nash created this revision.
Joe_Nash added reviewers: foad, arsenm, rampitec, kosarev, dstuttard, mbrkusanin.
Herald added subscribers: StephenFan, wenlei, kerbowa, hiraditya, tpr, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The 16-bit VAddr arguments to A16 image instructions are packed into
legal VGPR_32 operands in AMDGPULegalizerInfo::legalizeImageIntrinsic on
all subtargets. With True16, we also need to pack if the number of VAddr is one
because VGPR_16 is not a legal argument to those Image instructions.

No change to emitted code intended on subtargets pre-GFX11, and none on GFX11
until True16 is active.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157426

Files:
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.atomic.dim.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.dim.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.a16.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157426.548306.patch
Type: text/x-patch
Size: 157838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230808/eb65268b/attachment.bin>


More information about the llvm-commits mailing list