[PATCH] D157002: [MachineCSE] Add an option to do machine cse at all time regardless of profitable checking

JinGu Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 01:31:59 PDT 2023


jaykang10 added a comment.

Thanks.
Let me update the name.



================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:68
 
+static cl::opt<bool> AlwaysDoMachineCSE("always-do-machine-cse", cl::Hidden,
+                                        cl::init(false),
----------------
dmgreen wrote:
> Maybe name this AggressiveMachineCSE or something like it, to try and show that it overrides the profitability but not correctness.
Let me update the name with `AggressiveMachineCSE `.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:70
+                                        cl::init(false),
+                                        cl::desc("Always do machine cse"));
+
----------------
dmgreen wrote:
> Maybe "Override the profitability heuristics for Machine CSE"?
Let me update it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157002/new/

https://reviews.llvm.org/D157002



More information about the llvm-commits mailing list