[PATCH] D156414: [AMDGPU] Break Large PHIs: Take whole PHI chains into account

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 07:31:21 PDT 2023


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

I've been debating just introduce a late large register tuple splitting pass



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:1809
+  // multiple times, or even worse, doing it in a loop.
+  DenseSet<const PHINode *> WorkList;
+  collectPHINodes(I, WorkList);
----------------
These could probably be SmallPtrSets


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156414/new/

https://reviews.llvm.org/D156414



More information about the llvm-commits mailing list