[PATCH] D156215: [DAGCombiner] Reassociate the operands from (OR (OR(CMP1, CMP2)), CMP3) to (OR (OR(CMP1, CMP3)), CMP2)

Wed Aug 2 15:17:33 PDT 2023

arsenm added a comment.

In D156215#4552684 <https://reviews.llvm.org/D156215#4552684>, @kmitropoulou wrote:

> In D156215#4538242 <https://reviews.llvm.org/D156215#4538242>, @foad wrote:
>
>> Seems reasonable, but I wonder how often this helps in real code.
>
> I ran the Vulcan game tests. The reassociateOpsCommutative() is called 115168 times and the proposed optimization is triggered 302 times. So, I will abandon the patch.

That seems worthwhile? Why abandon it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156215/new/

https://reviews.llvm.org/D156215