[PATCH] D156622: [llvm-objdump] [NFC] Use a single vector to store all symbol mappings.

Jacek Caban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 12:14:16 PDT 2023


jacek added a comment.

In D156622#4554313 <https://reviews.llvm.org/D156622#4554313>, @foad wrote:

> Hi @jacek, this causes a few test failures if you configure with `-DLLVM_ENABLE_EXPENSIVE_CHECKS=ON -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=CSKY`:

I think I can see what's going wrong, sections like .csky.attributes may interleave with other sections in MappingSymbols. I will revert the patch and implement it differently, sorry about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156622/new/

https://reviews.llvm.org/D156622



More information about the llvm-commits mailing list