[PATCH] D156872: [MachineVerifier] Verify LiveIntervals for PHIs

[Jay Foad via Phabricator via llvm-commits]

foad added a reviewer: qcolombet.
foad added a comment.

Interesting. Currently I don't think anything in LLVM tries to use LiveIntervals in SSA form, does it? Even `-early-live-intervals` only creates them just after PHIElimination.



================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2530
+            if (MI->isPHI()) {
+              if (SR.getVNInfoAt(LiveOutIndex))
+                LiveInMask |= SR.LaneMask;
----------------
Could the phi and non-phi cases be commoned some more? Is there any good reason to use SR.getVNInfoAt in one case vs SR.Query in the other?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156872/new/

https://reviews.llvm.org/D156872