[PATCH] D145663: [Xtensa] Implement lowering constants.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 18:08:24 PDT 2023


arsenm added a comment.
Herald added a subscriber: sstefan1.

Tests?



================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:334
+  int64_t value = llvm::bit_cast<uint32_t>(CN->getValueAPF().convertToFloat());
+  if (Op.getValueType() == MVT::f32) {
+    Type *Ty = Type::getInt32Ty(*DAG.getContext());
----------------
can early return for != f32 and reduce indent


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145663/new/

https://reviews.llvm.org/D145663



More information about the llvm-commits mailing list