[PATCH] D156522: [LLVM] move verification of convergence control to a class template

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 09:41:40 PDT 2023


steven_wu added inline comments.


================
Comment at: llvm/include/llvm/ADT/GenericConvergenceVerifierImpl.h:34
+#include "llvm/ADT/Twine.h"
+#include "llvm/IR/Intrinsics.h"
+
----------------
This commit also breaks clang module. You cannot add a dependency from ADT -> IR. This will cause a cyclic dependency in modules between LLVM_Utils <-> LLVM_IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156522/new/

https://reviews.llvm.org/D156522



More information about the llvm-commits mailing list