[PATCH] D156315: [RFC][GlobalISel] Overhauled MIR Patterns Support for Combiners

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 08:00:59 PDT 2023


Pierre-vh updated this revision to Diff 546068.
Pierre-vh added a comment.

Split up OperandTable + add `named_operands()` accessor for InstructionPatterns.
There is one TODO in there about using a pair of OperandTables instead of a complicated RuleOperandTable, I plan to look into that as soon as I can but review can continue in the meantime (I can always fix it later if needed anyway, it's not broken - just a code improvement)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156315/new/

https://reviews.llvm.org/D156315

Files:
  llvm/docs/GlobalISel/MIRPatterns.rst
  llvm/docs/GlobalISel/index.rst
  llvm/docs/UserGuides.rst
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/GIMatchTableExecutor.cpp
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-imms.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-operand-types.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-patfrag-root.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-permutations.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-variadics.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/operand-types.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/patfrag-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing.td
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/CodeGenTarget.h
  llvm/utils/TableGen/GlobalISel/CodeExpansions.h
  llvm/utils/TableGen/GlobalISel/CombinerUtils.h
  llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTable.h
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156315.546068.patch
Type: text/x-patch
Size: 258077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230801/73e67bea/attachment-0001.bin>


More information about the llvm-commits mailing list