[PATCH] D154922: [BOLT] fix the endless loop of --iterative-guess

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 15:02:11 PDT 2023


rafauler accepted this revision.
rafauler added a comment.
This revision is now accepted and ready to land.

Thanks for the context, the fix looks good to me. Unfortunately, we can't check in the test as is because we can't guarantee the .fdata file will always make sense -- we would typically write this test in assembly language to guarantee offsets remain the same.

It's fine to commit this without the test as the fix is pretty clear now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154922/new/

https://reviews.llvm.org/D154922



More information about the llvm-commits mailing list