[PATCH] D131231: [LoongArch] Add codegen support for ISD::ROTL and ISD::ROTR

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 06:55:03 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/rotl-rotr.ll:374
+
+define i64 @rotl_64_mask_or_128_or_64(i64 %x, i64 %y) nounwind {
+; LA32-LABEL: rotl_64_mask_or_128_or_64:
----------------
@gonglingqin You might want to review theses tests as the out of bounds shifts means they generate poison (which is exploited by rGae60706da07a128) - maybe use fshl/fshr intrinsics?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131231/new/

https://reviews.llvm.org/D131231



More information about the llvm-commits mailing list