[PATCH] D150771: [RISCV] Set Fast flag for unaligned scalar memory accesses

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 13:43:25 PDT 2023


reames added a comment.
Herald added a subscriber: wangpc.

Reverse ping.

I spent some time looking at this over the last few days, and I think this makes sense to get landed.  I do want to request that you also enabled the Fast flag for the vector analogy flag.  From what I can tell, it causes no additional test diff, but doing them together is likely safer for two reasons.  First, it corresponds to the tested downstream config.  Second, a number of the merge transforms are in terms of comparisons of "how fast" operations are.  Thus having one set and not the other can result in odd results.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150771/new/

https://reviews.llvm.org/D150771



More information about the llvm-commits mailing list