[PATCH] D155857: [clang] fix nonnull warnings during build

Richard Smith - zygoloid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 12:13:16 PDT 2023


rsmith accepted this revision as: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.

Seems reasonable to me. Given that this affects all of LLVM I'd like to wait a day or so to see if anyone has concerns.



================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:774
+
+  append_if(CMAKE_COMPILER_IS_GNUCXX "-Wno-nonnull" CMAKE_CXX_FLAGS)
+
----------------
It'd be useful to leave a comment for future readers that we're disabling this due to false positives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155857/new/

https://reviews.llvm.org/D155857



More information about the llvm-commits mailing list