[PATCH] D155628: [OpenMP][OpenMPIRBuilder] Make outlined function parameters i64

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D155628#4514981 <https://reviews.llvm.org/D155628#4514981>, @arsenm wrote:

> In D155628#4514892 <https://reviews.llvm.org/D155628#4514892>, @jsjodin wrote:
>
>> In D155628#4512570 <https://reviews.llvm.org/D155628#4512570>, @jdoerfert wrote:
>>
>>> I would strongly recommend to make sure the arguments are 64 bit without i2p/p2i casts. This has all sorts of bad effects and it is a reason our clang kernels perform often poorly.
>>
>> If the size of a pointer is 64-bit can we use the pointers directly, unless pointers are 32-bit and then fall back on the i2p/p2i casts?

Sure. IIRC, we only support 64 bit pointers right now for offload.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155628/new/

https://reviews.llvm.org/D155628