[PATCH] D98183: [libLTO] Add support for -save-temps.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 16:35:50 PDT 2023


tejohnson added inline comments.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:633
+  if (Config.PostImportModuleHook)
+    Config.PostImportModuleHook(0, *MergedModule);
+
----------------
It doesn't really make sense to use the post import hook for regular LTO, since that is a ThinLTO-specific optimization. The new LTO API uses the PreOptModuleHook, which is a better fit here (see LTO::runRegularLTO in LTO.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98183/new/

https://reviews.llvm.org/D98183



More information about the llvm-commits mailing list