[PATCH] D155587: [AMDGPU][RFC] Update isLegalAddressingMode for GFX9 SMEM signed offsets

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 05:41:17 PDT 2023


foad added a reviewer: AMDGPU.
foad added a comment.

a) I don't know how to test this.
b) I'm not even sure if it's correct. Negative offsets are only allowed for regular SMEM loads/stores/atomics. For S_BUFFER_* the signed offset has to be >= 0. I don't know if this code is distinguishing those cases.
Any thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155587/new/

https://reviews.llvm.org/D155587



More information about the llvm-commits mailing list