[PATCH] D155404: [WIP][SimplifyCFG] Adjust sinking strategy for conditional predecessors.

[DianQK via Phabricator via llvm-commits]

DianQK abandoned this revision.
DianQK added a comment.

I will write the new idea in D155395 <https://reviews.llvm.org/D155395>.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2258
       // this transformation might be pessimizing. So as a rule of thumb,
       // don't do it unless we'd sink at least one non-speculatable instruction.
       // See https://bugs.llvm.org/show_bug.cgi?id=30244
----------------
xbolva00 wrote:
> Please add extra comment to explain your change.
This is a trick change in WIP.
I want to find a more suitable sink strategy to avoid missing out on some good opportunities.
I have reconsidered the optimization approach for D155395, and sink may not be the appropriate route.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155404/new/

https://reviews.llvm.org/D155404