[PATCH] D155441: [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 14:26:48 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.

> Allegedly, GCC-8 and above builds just fine.

It would be nice to test this:)



================
Comment at: llvm/include/llvm/ADT/iterator_range.h:47
+#if __GNUC__ == 7
+  // Be careful no to break gcc-7 on the mlir target.
+  // See https://github.com/llvm/llvm-project/issues/63843
----------------
If you know what things are specifically broken, better to use something like:

Work around a bug that ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155441/new/

https://reviews.llvm.org/D155441



More information about the llvm-commits mailing list