[PATCH] D155058: [Remark] Overload `<<` for Remark, RemarkType and RemarkLocation.

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Remarks/Remark.cpp:30
+  OS << "{ "
+     << "File: " << SourceFilePath << ", Ln: " << SourceLine
+     << " Col:" << SourceColumn << " }\n";
----------------
I suggest `Line` and `Column`, the difference is not that big.


================
Comment at: llvm/lib/Remarks/Remark.cpp:39
+void Remark::print(raw_ostream &OS) const {
+  OS << "RemarkName: ";
+  OS << RemarkName << "\n";
----------------
`Name` and `Type`? Remove `Remark` from the keys.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155058/new/

https://reviews.llvm.org/D155058