[PATCH] D153499: [RISCV] Add support for custom CSRs for Sifive S76.

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 01:25:39 PDT 2023


zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1839
+    auto CheckCSREncodingConflict = [&]() {
+      auto Reg = RISCVSysReg::lookupSiFiveRegByEncoding(SysReg->Encoding);
+      if (Reg && Reg->haveVendorRequiredFeatures(getSTI().getFeatureBits())) {
----------------
Could this move forward more?  Constructing more abstract infra to support all vendor reg instead of just SiFive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153499/new/

https://reviews.llvm.org/D153499



More information about the llvm-commits mailing list