[PATCH] D155301: [ARM] Replace TransferImpOps with copyImplicitOps

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 08:18:14 PDT 2023


john.brawn created this revision.
john.brawn added reviewers: Caslyn, stuij, simonwallis2, dmgreen.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
john.brawn requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In most places where TransferImpOps is currently used we just have one machine instruction, so it's doing the same thing as copyImplicitOps
anyway. In those cases where we have more than one machine instruction the destination is written to in each instruction so any implicit defs should appear on all of them (and we shouldn't see any implicit refs as these pseudo-instruction don't have any register inputs), meaning the current use of TransferImpOps is incorrect and we should be using copyImplicitOps on all of the generated instructions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155301

Files:
  llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp
  llvm/test/CodeGen/ARM/expand-pseudos.mir
  llvm/test/CodeGen/Thumb2/expand-pseudos.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155301.540426.patch
Type: text/x-patch
Size: 14118 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230714/99741d8c/attachment.bin>


More information about the llvm-commits mailing list