[PATCH] D153262: [llvm-objcopy] --set-section-flags: allow "large" to add SHF_X86_64_LARGE

Thu Jul 13 15:48:51 PDT 2023

tkoeppe marked 2 inline comments as done.
tkoeppe added inline comments.

================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:155
    section.
+ - `large` = add the `SHF_X86_64_LARGE` on x86_64, it is an error if the target
+   format is not x86_64.
----------------
MaskRay wrote:
> architecture is not x86_64.
> 
> I think the "target format" term is somewhat ambiguous. Sometimes it refers specifically to the object file format (LLVM may call it BinaryFormat): ELF, COFF, etc. Here we just mean the architecture (sometimes called processor or machine, but I find "architecture" better).
Done, changed to "architecture".

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153262/new/

https://reviews.llvm.org/D153262