[PATCH] D155125: [amdgpu][lds] Introduce LDS frame size function attribute

Thu Jul 13 06:41:45 PDT 2023

arsenm added a comment.

In D155125#4495465 <https://reviews.llvm.org/D155125#4495465>, @JonChesterfield wrote:

> In D155125#4495323 <https://reviews.llvm.org/D155125#4495323>, @arsenm wrote:
>
>> Should document what it means in AMDGPUUsage
>
> Maybe? The attributes section says "...backend supports the following LLVM IR attributes" which sounds user facing. While it's possible to set the attributes&metadata by hand and disable the lowering pass, doing so would take a fair amount of reverse engineering. I'm happier leaving this undocumented.

I think it should be documented. Not documenting it is no obstacle to people using it, and using it in however they decide it works. The backend should also try to tolerate existing uses of it, else we break the invariant that running a pass twice shouldn't break anything. We do document some other attributes people are better off not touching themselves as it is

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155125/new/

https://reviews.llvm.org/D155125