[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

Thanks for changes,

there are failures during pre-integration testing. They need to be fixed before integration of this patch. I the problem could probably be fixed by adding check for empty ranges into the DIECloner::emitDebugAddrSection():

  if (Addrs.empty())
    return;



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:704
+    void emitDebugAddrSection(CompileUnit &Unit, SmallVector<uint64_t> &Addrs,
+                              const uint16_t DwarfVersion) const;
+
----------------
No need to pass Addrs as AddrPool is a member of DIECloner.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-addr_base.test:1
+; This test checks to ensure that if two DWARF v5 object files have correct values for the DW_AT_addr_base in their compile units.
+
----------------



================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-addr_base.test:49
+RUN: rm -rf %t.dir && mkdir -p %t.dir
+RUN: dsymutil -y %p/dummy-debug-map-amr64.map -oso-prepend-path=%p/../Inputs/DWARF5-addr_base -o %t.dir/dwarf5-addr_base.dSYM
+RUN: llvm-dwarfdump %t.dir/dwarf5-addr_base.dSYM -a --verbose | FileCheck %s
----------------
add a check for "-u" case, please.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638