[PATCH] D155087: [CodeGen] Fix assertion failure caused by inline assembly

[Bryan Chan via Phabricator via llvm-commits]

bryanpkc added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:838
       MI.emitError("inline assembly requires more registers than available");
+      report_fatal_error("inline assembly requires more registers than available", false);
+    }
----------------
bryanpkc wrote:
> `MachineInstr::emitError` falls back to calling `report_fatal_error` if it cannot find a `MCContext`. Making an additional call to `report_fatal_error` here doesn't feel right. Why isn't `MI.emitError` able to stop the compiler before it crashes?
> `MachineInstr::emitError` falls back to calling `report_fatal_error` if it cannot find a `MCContext`.

I meant `LLVMContext`, not `MCContext`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155087/new/

https://reviews.llvm.org/D155087