[PATCH] D109192: Support: introduce public API annotation support

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 13:45:40 PDT 2023


rnk accepted this revision.
rnk added a comment.

In D109192#4486728 <https://reviews.llvm.org/D109192#4486728>, @tstellar wrote:

> In D109192#4486226 <https://reviews.llvm.org/D109192#4486226>, @rnk wrote:
>
>> If we're not making a separate DLL for LLVM support, that sounds fine to me.
>>
>> I'm worried that by limiting scope here, we're just deferring the discovery and resolution of problems that @compnerd already grappled with in his attempt to make LLVM DLLs, but it's also good to be incremental and get things moving.
>
> I've got a WIP patch to add annotations to the rest of the ABI, I can merge that into this one if you think that's better.

Either approach seems fine to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192



More information about the llvm-commits mailing list