[PATCH] D154655: [DebugInfo] Force users of DWARFDebugAbbrev to call parse before iterating

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 10:16:11 PDT 2023


bulbazord marked an inline comment as done.
bulbazord added inline comments.


================
Comment at: bolt/lib/Core/DebugData.cpp:1301
       if (AbbrevSetOffsets.empty()) {
+        const DWARFDebugAbbrev *DebugAbbrev =
+            Unit.getContext().getDebugAbbrev();
----------------
ayermolo wrote:
> Assuming my changes won't be reverted BOLT no longer uses this method.
Good to know. For now, it was causing test failures so I'm going to land this with this change. It'll just go away when we're able to delete this method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154655/new/

https://reviews.llvm.org/D154655



More information about the llvm-commits mailing list