[PATCH] D154281: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 08:20:53 PDT 2023


foad added a comment.

In D154281#4493465 <https://reviews.llvm.org/D154281#4493465>, @arsenm wrote:

> Should the verifier check the block stored adjustment matches the calls in the block?

That would be nice, and it would fit naturally in MachineVerifier::verifyStackFrame. But after PEI eliminates call frame setup instructions, you can no longer infer the SP adjustment by examining the instructions in a block. I don't know how to handle that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154281/new/

https://reviews.llvm.org/D154281



More information about the llvm-commits mailing list