[PATCH] D154528: [Codegen] Generate fast fp64-to-fp16 conversions in unsafe mode.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 06:46:56 PDT 2023


kosarev added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6264-6265
   auto [Dst, Src] = MI.getFirst2Regs();
+  assert(MRI.getType(Dst).getScalarType() == S16 &&
+         MRI.getType(Src).getScalarType() == S64);
+
----------------
chapuni wrote:
> `S16` and `S64` are used only here in -Asserts.
Fixed in rGe705b2b1f4a7, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154528/new/

https://reviews.llvm.org/D154528



More information about the llvm-commits mailing list