[PATCH] D144936: [SPARC][IAS] Recognize more SPARCv9 instructions/pseudoinstructions
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 11 18:00:46 PDT 2023
arsenm added a comment.
Code seems mostly fine but I know nothing about sparc
================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:708-712
+ const MCExpr *ValExpr;
+ if (IsImm)
+ ValExpr = MCConstantExpr::create(ImmValue, getContext());
+ else
+ ValExpr = MCValOp.getExpr();
----------------
Initialize with ternary operator?
================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:1242
+ return MatchOperand_ParseFail;
+ std::unique_ptr<SparcOperand> NewMemOp = SparcOperand::MorphToMEMri(
+ OldMemOp.getMemBase(),
----------------
needing allocation for MC operands seems unusual?
================
Comment at: llvm/lib/Target/Sparc/MCTargetDesc/SparcInstPrinter.cpp:246
+ if (ASITag)
+ O << "#" << ASITag->Name;
+ else
----------------
Single quotes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144936/new/
https://reviews.llvm.org/D144936
More information about the llvm-commits
mailing list