[PATCH] D154938: [InstCombine] Test cases for D154937

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/InstCombine/and-or-icmp-const-icmp.ll:503
+  ret <2 x i1> %and
+}
+
----------------
I'd personally save a lot of these tests -- generally we want to see one test of each "kind", but not every possible combination. So a test for eq, ne, vectors and mismatched constants each, rather than all 8 combinations of eq/ne, scalar/vector and matching/mismatching for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154938/new/

https://reviews.llvm.org/D154938