[llvm] 0fd4175 - [ifs] IFSStub destructor should be virtual

Haowei Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 12:49:01 PDT 2023


Author: Amirreza Ashouri
Date: 2023-07-10T12:48:32-07:00
New Revision: 0fd4175907b40fe63131482c162d7e0f76000521

URL: https://github.com/llvm/llvm-project/commit/0fd4175907b40fe63131482c162d7e0f76000521
DIFF: https://github.com/llvm/llvm-project/commit/0fd4175907b40fe63131482c162d7e0f76000521.diff

LOG: [ifs] IFSStub destructor should be virtual

This patch makes IFSStub class's destructor virtual to avoid
undefined behavior when it points to its child class's object and
got deleted.

Differential Revision: https://reviews.llvm.org/D154776

Added: 
    

Modified: 
    llvm/include/llvm/InterfaceStub/IFSStub.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/InterfaceStub/IFSStub.h b/llvm/include/llvm/InterfaceStub/IFSStub.h
index cd7704146ab96f..09f96f72950cf6 100644
--- a/llvm/include/llvm/InterfaceStub/IFSStub.h
+++ b/llvm/include/llvm/InterfaceStub/IFSStub.h
@@ -97,6 +97,7 @@ struct IFSStub {
   IFSStub() = default;
   IFSStub(const IFSStub &Stub);
   IFSStub(IFSStub &&Stub);
+  virtual ~IFSStub() = default;
 };
 
 // Create a alias class for IFSStub.


        


More information about the llvm-commits mailing list