[PATCH] D146266: gn build: Fix Android build.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 10 05:10:11 PDT 2023
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
lg
(aeubanks, feel free to approve changes like this!)
================
Comment at: llvm/utils/gn/build/BUILDCONFIG.gn:53
+
+foreach(target_type,
+ [
----------------
This is a bit yucky. Maybe we could do this `if (current_os == "android")` for now, since we at least currently only need it there? (If so, let `group("implicit")` only exist on android too)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146266/new/
https://reviews.llvm.org/D146266
More information about the llvm-commits
mailing list