[PATCH] D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass

Fri Jul 7 00:22:15 PDT 2023

mgabka added a comment.

In the proposed new commit message you mention neon, but to me looks like the bug isn't neon specific, and could be triggered by scalable vectors, am I correct?
shall we have a separate test for scalable vectors?

If that is correct could you adjust the commit message?

================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-reductions.ll:241
+; The reduced bug from D153355. Shows that reduction was detected where it did not exist.
+define void @bug(i1 %exitcond.not) #0 {
+; CHECK-LABEL: bug:
----------------
mgabka wrote:
> mgabka wrote:
> > there is no attribute like that, I guess it can be removed, or if attribute was relevant for this test it needs to be added
> I have a general comment about this test, to me looks like it can be simplified and do not use the aarch64 specific intrinsics,  isn't it the case that we have only fadd here but no load/store instructions?
Thanks Igor for adjusting the test, I have a few more comments/requests:
1. Could you change the function name to something more descriptive? Like incorrect_reduction_pattern or something similar
2. remove the numbers fro, variable names (it will make it easier to read)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154598/new/

https://reviews.llvm.org/D154598