[PATCH] D154069: [IRCE] Parse range checks in the form of "LHS - RHS vs Limit"

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

One comment, other looks good...



================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:474
+  if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) {
+    // "Expr <= Limit" -> "Expr < Limit + 1"
+    if (Pred == ICmpInst::ICMP_SLE && Limit)
----------------
what if you did not scale and Limit == S_INT_MAX? Limit + 1 will overflow then?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154069/new/

https://reviews.llvm.org/D154069