[PATCH] D154630: [LLVM-C] Use unwrapDI in LLVMDITypeGetName

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 15:14:04 PDT 2023


scott.linder added a comment.

Could you split the NFC changes to naming/style from the functional fix to `LLVMDITypeGetName` and the new test?



================
Comment at: llvm/tools/llvm-c-test/debuginfo.c:247
+      LLVMDIFlagObjcClassComplete, NULL, NULL, 0, 0, NULL, NULL, 0);
+  assert(LLVMGetDINodeTag(Struct) == 0x13);
+
----------------
This seems redundant with `llvm_get_di_tag`, maybe it can be dropped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154630/new/

https://reviews.llvm.org/D154630



More information about the llvm-commits mailing list