[PATCH] D154622: [AArch64] Fix cost modelling for SVE Min/Max Intrinsics

Thu Jul 6 10:55:51 PDT 2023

dmgreen added a comment.

Thanks, Looks good. Can you split out the tests? I think this has included the two patches together.

And remember to upload with context. https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch

================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-min-max.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt < %s -mtriple=aarch64-unknown-linux-gnu -mattr=+sve -passes="print<cost-model>" 2>&1 -disable-output -cost-kind=throughput | FileCheck %s --check-prefixes=CHECK,CHECK-NOF16
+
----------------
This can remove the  --check-prefixes=CHECK,CHECK-NOF16, as it won't be needed for sve tests.

================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-min-max.ll:346
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; CHECK-NOF16: {{.*}}
----------------
And so this can be removed too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154622/new/

https://reviews.llvm.org/D154622