[compiler-rt] 88b9d4d - [XRay][test] Replace some XFAIL with more appropriate REQUIRES

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 20:06:40 PDT 2023


Author: Fangrui Song
Date: 2023-07-05T20:06:37-07:00
New Revision: 88b9d4d77e09e52b2da4760a300e0e30df27ac07

URL: https://github.com/llvm/llvm-project/commit/88b9d4d77e09e52b2da4760a300e0e30df27ac07
DIFF: https://github.com/llvm/llvm-project/commit/88b9d4d77e09e52b2da4760a300e0e30df27ac07.diff

LOG: [XRay][test] Replace some XFAIL with more appropriate REQUIRES

Added: 
    

Modified: 
    compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp
    compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp
    compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp b/compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp
index 7125f191b901d6..fea9054d2efdee 100644
--- a/compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp
+++ b/compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp
@@ -4,10 +4,8 @@
 // RUN: rm -f arg0-arg1-logging-*
 // RUN: %clangxx_xray -std=c++11 %s -o %t
 // RUN: XRAY_OPTIONS="patch_premain=true verbosity=1 xray_logfile_base=arg0-arg1-logging-" %run %t
-//
-// TODO: Support these in ARM and PPC
-// XFAIL: target={{(arm|aarch64|mips).*}}
-// UNSUPPORTED: target=powerpc64le{{.*}}
+
+// REQUIRES: target={{x86_64-.*}}
 
 #include "xray/xray_interface.h"
 #include <cassert>

diff  --git a/compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp b/compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp
index ee957af6c84e80..443f74c4821308 100644
--- a/compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp
+++ b/compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp
@@ -9,11 +9,8 @@
 // After all that, clean up the XRay log file.
 //
 // RUN: rm -f arg1-logger-*
-//
-// At the time of writing, the ARM trampolines weren't written yet.
-// XFAIL: target={{(arm|aarch64|mips).*}}
-// See the mailing list discussion of r296998.
-// UNSUPPORTED: target=powerpc64le{{.*}}
+
+// REQUIRES: target={{x86_64-.*}}
 
 #include "xray/xray_interface.h"
 

diff  --git a/compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp b/compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp
index 938383e2ec874f..e85a1d5474cedb 100644
--- a/compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp
+++ b/compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp
@@ -4,8 +4,8 @@
 // RUN: rm -f log-args-this-*
 // RUN: XRAY_OPTIONS="patch_premain=true verbosity=1 xray_logfile_base=log-args-this-" %run %t
 //
-// XFAIL: target={{(arm|aarch64|mips).*}}
-// UNSUPPORTED: target=powerpc64le{{.*}}
+// REQUIRES: target={{x86_64-.*}}
+
 #include "xray/xray_interface.h"
 #include <cassert>
 


        


More information about the llvm-commits mailing list