[PATCH] D154553: [YAML][NFC] Replace if-else with switch in createHNodes

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 15:48:51 PDT 2023


Amir added a comment.

@njames93, @silvas, @grimar, @thomasfinch, @Bigcheese, @hintonda – folks, I checked blame on this function and picked you as most recent authors and reviewers.

I'm also looking for suggestions on how to speed up this function and parsing YAML in general. First thing that stands out in the profile is that we do allocate a lot of `Node`s. But since they're allocated using BumpPtrAllocator I don't see much room for improvement here: 
https://github.com/llvm/llvm-project/blob/49dfbc6efc64bcd9031bc80fd20f4be080ebf56e/llvm/include/llvm/Support/YAMLParser.h#L141


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154553/new/

https://reviews.llvm.org/D154553



More information about the llvm-commits mailing list