[PATCH] D153748: [RISCV] Add support for XCValu extension in CV32E40P

Tue Jul 4 02:12:09 PDT 2023

realqhc added inline comments.

================
Comment at: llvm/docs/RISCVUsage.rst:278
+``XCValu``
+  LLVM implements `version 1.3.1 of the Core-V ALU custom instructions specification <https://github.com/openhwgroup/cv32e40p/blob/4f024fe4b15a68b76615b0630c07a6745c620da7/docs/source/instruction_set_extensions.rst>`_ by Core-V.  All instructions are prefixed with `cv.mac.` as described in the specification. These instructions are only available for riscv32 at this time.
----------------
craig.topper wrote:
> kito-cheng wrote:
> > realqhc wrote:
> > > kito-cheng wrote:
> > > > @jeremybennett say it's 1.0 here?
> > > > 
> > > > https://github.com/riscv-non-isa/riscv-toolchain-conventions/blob/master/README.mkd#list-of-vendor-extensions
> > > This might need to be updated as if you check https://github.com/openhwgroup/cv32e40p/releases, there has been release of v1.3.2 last week. 
> > I saw binutils from openhwgroup still using 1.0[1], and that patch is committed 5 days ago? I am not intend to block this patch, but I would like to figure out what's the right version for those extension.
> > 
> > [1] https://github.com/openhwgroup/corev-binutils-gdb/commit/9b120787924eed13455de3062523539dc39bc7f8
> The cv.mac part was copied from another description and does not apply here.
Should I change it to cv. like XCVbitmanip or do you think cv.alu is more appropriate here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153748/new/

https://reviews.llvm.org/D153748