[PATCH] D154364: [LTO] Allow library calls to be internalized in freestanding mode

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 added inline comments.


================
Comment at: llvm/lib/Object/IRSymtab.cpp:278
+  if (IsPreservedSymbol)
+    Sym.Flags |= 1 << storage::Symbol::FB_libcall;
   if (GV->isThreadLocal())
----------------
jdoerfert wrote:
> This is how we find out it is a libcall? If so, then we might want to rename the bool above, maybe even more.
I think it used to be called "IsBuiltinFunc", but it got renamed to this more generically because there's like`__ssp_canary_word`, and `__stack_chk_guard` aren't contained in `llvm/IR/RuntimeLibcalls.def`. We may need to filter those out here thinking about it, since they're not true library calls but will be marked as such.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154364/new/

https://reviews.llvm.org/D154364