[PATCH] D154233: [ARM] generate correct code for armv6-m XO big stack operations

Mon Jul 3 06:37:41 PDT 2023

stuij marked an inline comment as done.
stuij added inline comments.

================
Comment at: llvm/test/CodeGen/ARM/large-stack.ll:24
+; CHECK-NEXT: lsls    [[REG]], [[REG]], #0x8
+; CHECK-NEXT: adds    [[REG]], #0xb8
     %tmp = alloca [ 4168 x i8 ] , align 4
----------------
efriedma wrote:
> The generated code here is ridiculously inefficient; do you have some plan for generating code that's closer to optimal?
Luckily armv6-M XO is a partner-requested feature. The current timeline is that we will first make it functionally work (which seems reasonable to me). Then we will benchmark and compare it with XO turned off. We will discuss the result and will optimise where needed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154233/new/

https://reviews.llvm.org/D154233