[PATCH] D154337: [AMDGPU] Eliminate SIMCCodeEmitter and de-virtualise encoding methods.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 05:36:27 PDT 2023


kosarev added a comment.

> Looks like a nice cleanup to me but can you please rename `SIMCCodeEmitter.cpp` to `AMDGPUMCCodeEmitter.cpp` to match the class name, either in this patch or a separate patch?

Sure, will do with a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154337/new/

https://reviews.llvm.org/D154337



More information about the llvm-commits mailing list