[PATCH] D149091: [Object] Recognize ARM64EC binaries in COFFObjectFile::getMachine.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The new yaml2obj-based test certainly looks reasonable to me. However, it looks like there are three code paths now, and the test only tests one of them. The case where `CHPEMetadata` is false/nullptr/whatever is possibly covered by other tests(?), but I think you also need to test the other part of the switch you've added? (I don't know anything really about the code area to give any particular guidance about it though).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149091/new/

https://reviews.llvm.org/D149091