[PATCH] D154319: [MIPS] Replace OperandMatchResultTy with ParseStatus (NFC)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 21:08:12 PDT 2023


barannikov88 created this revision.
Herald added subscribers: atanasyan, jrtc27, hiraditya, arichardson, sdardis.
Herald added a project: All.
barannikov88 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

  return Error(L, "msg");

when with MatchOperandResultTy it had to be:

  Error(L, "msg");
  return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154319

Files:
  llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154319.536656.patch
Type: text/x-patch
Size: 21955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230703/087a8144/attachment.bin>


More information about the llvm-commits mailing list