[PATCH] D137398: lib/CodeGen: Compile with -fvisibility=hidden when possible

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/CMakeLists.txt:1183
 
+if (NOT BUILD_SHARED_LIBS AND NOT APPLE AND
+    (NOT (WIN32 OR CYGWIN) OR (MINGW AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")) AND
----------------
This condition is pretty unmanageable IMO.  Can we perhaps split it up into a set of named conditions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137398/new/

https://reviews.llvm.org/D137398