[PATCH] D153326: [CSKY] Optimize subtraction with SUBI32/SUBI16

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 06:17:52 PDT 2023


benshi001 added a comment.

In D153326#4462511 <https://reviews.llvm.org/D153326#4462511>, @zixuan-wu wrote:

> In D153326#4462460 <https://reviews.llvm.org/D153326#4462460>, @benshi001 wrote:
>
>> In D153326#4462433 <https://reviews.llvm.org/D153326#4462433>, @zixuan-wu wrote:
>>
>>> BTW, as the check-all test is not enough, have you run llvm-test-suite sometimes although it's not needed every patch? I think should run llvm-test-suite in qemu from time to time.
>>
>> Thanks. I will try. Further questions,
>>
>> 1. Is there any QEMU pre-build package I can use?
>> 2. Also csky-binutils pre-build package, where I can download?
>> 3. Any other tools are needed to run llvm-test-suite ? Is there a wiki page for that ?
>
>
>
> 1. You can download at https://xuantie.t-head.cn/community/download?id=4168444414324183040
> 2. clang on csky depends to gcc runtime so it needs gcc toolchain, you can download at https://xuantie.t-head.cn/community/download?id=3854599713706024960
> 3. Sorry about no document to describe the run process of llvm-test-suite in csky. But there is llvm build bot you can refer to. https://lab.llvm.org/staging/#/builders/215/builds/2795

I have run the `SingleSource` and `MultiSource` of the llvm-test-suite with this patch applied, there are several failures, and several link errors.

Failures of `SingleSource`

  ********************
  ********************
  Failed Tests (1):
    test-suite :: SingleSource/Benchmarks/SmallPT/smallpt.test
  
  
  Testing Time: 11971.65s
    Passed: 324
    Failed:   1

Failures of `MultiSource`

  ********************
  ********************
  Failed Tests (4):
    test-suite :: MultiSource/Applications/ClamAV/clamscan.test
    test-suite :: MultiSource/Benchmarks/SciMark2-C/scimark2.test
    test-suite :: MultiSource/Benchmarks/TSVC/NodeSplitting-dbl/NodeSplitting-dbl.test
    test-suite :: MultiSource/Benchmarks/mafft/pairlocalalign.test
  
  
  Testing Time: 11903.17s
    Passed: 185
    Failed:   4

And the cases disabled for link errors

  MultiSource/Benchmarks/Bullet
  MultiSource/Benchmarks/tramp3d-v4
  MultiSource/Benchmarks/7zip
  MultiSource/Benchmarks/PAQ8p
  SingleSource/Benchmarks/Misc-C++-EH
  SingleSource/Regression/C++/2003-06-08-BaseType.cpp
  SingleSource/UnitTests/AtomicOps.c

Is that result OK?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153326/new/

https://reviews.llvm.org/D153326



More information about the llvm-commits mailing list