[PATCH] D154291: [RISCV] Replace OperandMatchResultTy with ParseStatus (NFC)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 1 16:16:55 PDT 2023


barannikov88 created this revision.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
barannikov88 requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, eopXD, MaskRay.
Herald added a project: LLVM.

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

  return Error(L, "msg");

when with MatchOperandResultTy it had to be:

  Error(L, "msg");
  return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154291

Files:
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154291.536557.patch
Type: text/x-patch
Size: 34917 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230701/948beeef/attachment.bin>


More information about the llvm-commits mailing list