[PATCH] D154106: [NVPTX] added a hidden option to control NVPTXLowerUnreachable pass.
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 30 08:35:26 PDT 2023
tra added inline comments.
================
Comment at: llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp:413
+ if (ExitOnUnreachable)
+ addPass(createNVPTXLowerUnreachablePass());
}
----------------
alexfh wrote:
> alexfh wrote:
> > nit: Looks like a tab character. clang-format, please
> IIUC, pre-merge checks are complaining about formatting: https://buildkite.com/llvm-project/premerge-checks/builds/161426#01890803-0fee-40a1-a9b3-d1d55a200ede
This is odd. It's all-spaces in my source file. Here's hexdump of that part of the diff:
```
00000590 6c 65 50 61 73 73 28 29 29 3b 0a 2b 20 20 69 66 |lePass());.+ if|
000005a0 20 28 45 78 69 74 4f 6e 55 6e 72 65 61 63 68 61 | (ExitOnUnreacha|
000005b0 62 6c 65 29 0a 2b 20 20 20 20 61 64 64 50 61 73 |ble).+ addPas|
000005c0 73 28 63 72 65 61 74 65 4e 56 50 54 58 4c 6f 77 |s(createNVPTXLow|
000005d0 65 72 55 6e 72 65 61 63 68 61 62 6c 65 50 61 73 |erUnreachablePas|
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154106/new/
https://reviews.llvm.org/D154106
More information about the llvm-commits
mailing list